Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(profiling) fix profiling ASAN tests #2924

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

realFlowControl
Copy link
Member

@realFlowControl realFlowControl commented Nov 5, 2024

Description

This PR bumps Rust Nightly to 2024-11-04 to be able to run ASAN tests again. Additionally in order to get the bookworm containers compile in our CI, it bumps LLVM there to 17 (like we did for the buster containers already) and adds a PHP 8.4 ASAN run.

PROF-10137

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@github-actions github-actions bot added the profiling Relates to the Continuous Profiler label Nov 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.96%. Comparing base (1b40137) to head (23bd154).
Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2924      +/-   ##
============================================
+ Coverage     72.39%   73.96%   +1.57%     
  Complexity     2526     2526              
============================================
  Files           135      108      -27     
  Lines         14400    10360    -4040     
  Branches        989        0     -989     
============================================
- Hits          10425     7663    -2762     
+ Misses         3433     2697     -736     
+ Partials        542        0     -542     
Flag Coverage Δ
appsec-extension ?
tracer-php 73.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b40137...23bd154. Read the comment docs.

@realFlowControl realFlowControl self-assigned this Nov 5, 2024
@realFlowControl realFlowControl force-pushed the florian/fix-asan-github-action branch from ba15d3c to 9d1854a Compare November 5, 2024 15:46
@realFlowControl realFlowControl force-pushed the florian/fix-asan-github-action branch from 9d1854a to 8f5015d Compare November 5, 2024 16:41
@realFlowControl realFlowControl force-pushed the florian/fix-asan-github-action branch from c2b6c56 to e5475b9 Compare November 6, 2024 13:24
@realFlowControl realFlowControl force-pushed the florian/fix-asan-github-action branch from e5475b9 to 23bd154 Compare November 6, 2024 13:25
@realFlowControl realFlowControl marked this pull request as ready for review November 6, 2024 13:32
@realFlowControl realFlowControl requested a review from a team as a code owner November 6, 2024 13:32
Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@realFlowControl realFlowControl merged commit 1fcf623 into master Nov 6, 2024
407 of 473 checks passed
@realFlowControl realFlowControl deleted the florian/fix-asan-github-action branch November 6, 2024 13:39
@github-actions github-actions bot added this to the 1.5.0 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci profiling Relates to the Continuous Profiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants